[webkit-reviews] review granted: [Bug 235154] Add to Contact menu item does nothing on mac. : [Attachment 448993] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 12 14:02:31 PST 2022

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 235154: Add to Contact menu item does nothing on mac.

Attachment 448993: Patch


--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 448993
  --> https://bugs.webkit.org/attachment.cgi?id=448993

View in context: https://bugs.webkit.org/attachment.cgi?id=448993&action=review

Please make sure there's a bug tracking adopting TextIndicator here instead of
just hiding the highlight.

> Source/WebKit/UIProcess/PageClient.h:436
> +    virtual NSView *activeView() const = 0;

In order to make this less tempting, maybe we can call it

> Source/WebKit/UIProcess/mac/PageClientImplMac.h:230
> -    NSView *activeView() const;
> +    NSView *activeView() const override;

And then here in the mac impl you'll just turn around and call activeView...

More information about the webkit-reviews mailing list