[webkit-reviews] review requested: [Bug 234155] [Shadow Realms] Use WebCore module loaders for shadow realm importValue : [Attachment 448861] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 12 12:09:26 PST 2022
Joseph Griego <jgriego at igalia.com> has asked for review:
Bug 234155: [Shadow Realms] Use WebCore module loaders for shadow realm
importValue
https://bugs.webkit.org/show_bug.cgi?id=234155
Attachment 448861: Patch
https://bugs.webkit.org/attachment.cgi?id=448861&action=review
--- Comment #16 from Joseph Griego <jgriego at igalia.com> ---
Comment on attachment 448861
--> https://bugs.webkit.org/attachment.cgi?id=448861
Patch
I believe this version addresses the lifetime issues--whenever creating a
shadow realm for a DOM context, we walk up the document tree as far as possible
while staying in the same DOMWrapperWorld and use that document's wrapper as
the delegate for module fetches.
More information about the webkit-reviews
mailing list