[webkit-reviews] review granted: [Bug 229120] Allow a same-origin <iframe> to programmatically navigate its top frame to an external URL : [Attachment 441796] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Alexey Shvayka
<ashvayka at apple.com>'s request for review:
Bug 229120: Allow a same-origin <iframe> to programmatically navigate its top
frame to an external URL
https://bugs.webkit.org/show_bug.cgi?id=229120

Attachment 441796: Patch

https://bugs.webkit.org/attachment.cgi?id=441796&action=review




--- Comment #6 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 441796
  --> https://bugs.webkit.org/attachment.cgi?id=441796
Patch

r=me

I recommend double-checking where the ShouldOpenExternalURLsPolicy originates
in the navigation request, and verifying that it enforces a main frame
requirement.