[webkit-reviews] review granted: [Bug 234740] [GTK][a11y] Defer the emission of AddAccessible signal with ATSPI : [Attachment 448916] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 12 03:31:35 PST 2022


Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 234740: [GTK][a11y] Defer the emission of AddAccessible signal with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=234740

Attachment 448916: Patch

https://bugs.webkit.org/attachment.cgi?id=448916&action=review




--- Comment #9 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 448916
  --> https://bugs.webkit.org/attachment.cgi?id=448916
Patch

Patch LGTM with a small nit to fix before landing ��️

View in context: https://bugs.webkit.org/attachment.cgi?id=448916&action=review

> Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp:-29
> -#include <wtf/NeverDestroyed.h>

Do not remove the line for <wtf/NeverDestroyed.h>, because it will break
non-unified builds.


More information about the webkit-reviews mailing list