[webkit-reviews] review granted: [Bug 234447] null ptr deref while trying to access DeferredPromise::promise() : [Attachment 448858] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gabriel Nava Marino
<gnavamarino at apple.com>'s request for review:
Bug 234447: null ptr deref while trying to access DeferredPromise::promise()
https://bugs.webkit.org/show_bug.cgi?id=234447

Attachment 448858: Patch

https://bugs.webkit.org/attachment.cgi?id=448858&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 448858
  --> https://bugs.webkit.org/attachment.cgi?id=448858
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448858&action=review

> Source/WebCore/bindings/js/JSDOMPromiseDeferred.cpp:47
> +    if (isEmpty())

Other functions in this class use shouldIgnoreRequestToFulfill rather than
calling isEmpty directly. Did you consider that?