[webkit-reviews] review granted: [Bug 235073] [GPU Process] [SVG Resources] Make SVG resources create remote ImageBuffers for their drawing : [Attachment 448852] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 235073: [GPU Process] [SVG Resources] Make SVG resources create remote
ImageBuffers for their drawing
https://bugs.webkit.org/show_bug.cgi?id=235073

Attachment 448852: Patch

https://bugs.webkit.org/attachment.cgi?id=448852&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 448852
  --> https://bugs.webkit.org/attachment.cgi?id=448852
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448852&action=review

> Source/WebCore/ChangeLog:3
> +	   [GPU Process] Make SVG resources create remote ImageBuffers for
their drawing

Is there a way to test that this has the desired result?

> Source/WebKit/GPUProcess/graphics/QualifiedResourceHeap.h:164
> +	   if (!std::holds_alternative<Ref<T>>(iterator->value))
> +	       return nullptr;
>	   return std::get<Ref<T>>(iterator->value).ptr();

Would be nice to use get_if instead of calling holds_alternative and then get.
Would reduce reference count churn, and code would be less repetitive:

    auto value = std::get_if<Ref<T>>(&iterator->value);
    return value ? value->ptr() : nullptr;