[webkit-reviews] review granted: [Bug 234886] Add some functions to Color to make debugging using color indicators easier : [Attachment 448753] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 234886: Add some functions to Color to make debugging using color
indicators easier
https://bugs.webkit.org/show_bug.cgi?id=234886

Attachment 448753: Patch

https://bugs.webkit.org/attachment.cgi?id=448753&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 448753
  --> https://bugs.webkit.org/attachment.cgi?id=448753
Patch

Do we need to add a keyword to make sure this never gets dead-code stripped?

Should these be non-member functions? In WTFString.cpp, string and asciiDebug
are, but String::show is a member function. One advantage is that the functions
don’t have to be in the header. But maybe they are easier to call?