[webkit-reviews] review granted: [Bug 235034] Use the new template ColorSpaceCG helpers to cleanup some code : [Attachment 448805] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 10 18:18:22 PST 2022


Cameron McCormack (:heycam) <heycam at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 235034: Use the new template ColorSpaceCG helpers to cleanup some code
https://bugs.webkit.org/show_bug.cgi?id=235034

Attachment 448805: Patch

https://bugs.webkit.org/attachment.cgi?id=448805&action=review




--- Comment #4 from Cameron McCormack (:heycam) <heycam at apple.com> ---
Comment on attachment 448805
  --> https://bugs.webkit.org/attachment.cgi?id=448805
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448805&action=review

> Source/WebCore/platform/graphics/cg/GradientRendererCG.cpp:511
> +    using OutputSpaceColorType =
std::conditional_t<HasCGColorSpaceMapping<ColorSpace::ExtendedSRGB>,
ExtendedSRGBA<float>, SRGBA<float>>;

Since this declaration to choose "ExtendedSRGB if supported else SRGB" is used
in a bunch of places, maybe it should be in CGColorSpace.h? Maybe a templated
using statement (so float is still specified explicitly)?


More information about the webkit-reviews mailing list