[webkit-reviews] review granted: [Bug 233072] ::backdrop pseudo element should react to event listeners : [Attachment 448789] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 10 17:31:37 PST 2022

zalan <zalan at apple.com> has granted Tim Nguyen (:ntim) <ntim at apple.com>'s
request for review:
Bug 233072: ::backdrop pseudo element should react to event listeners

Attachment 448789: Patch


--- Comment #4 from zalan <zalan at apple.com> ---
Comment on attachment 448789
  --> https://bugs.webkit.org/attachment.cgi?id=448789

View in context: https://bugs.webkit.org/attachment.cgi?id=448789&action=review

> Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:201
> -    // Update or attach to renderer parent
> +    // Update or attach to renderer
>      WeakPtr currentParent = backdropRenderer->parent();
> -    WeakPtr newParent = renderer.parent();
> +    WeakPtr newParent = renderer;

auto backdropRenderer = renderer.backdropRenderer();

don't we always end up either with no backdropRenderer or with one with the
correct parent (renderer)? I didn't look through all the cases but could you
explain the re-parenting case? (if no reparenting ever happens, we could make
this function a lot simpler)

More information about the webkit-reviews mailing list