[webkit-reviews] review granted: [Bug 235045] [Cocoa] Inspector Extensions: tabIconURLs with custom scheme URLs are incorrectly loaded : [Attachment 448802] Patch v1.1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted BJ Burg <bburg at apple.com>'s request
for review:
Bug 235045: [Cocoa] Inspector Extensions: tabIconURLs with custom scheme URLs
are incorrectly loaded
https://bugs.webkit.org/show_bug.cgi?id=235045

Attachment 448802: Patch v1.1

https://bugs.webkit.org/attachment.cgi?id=448802&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 448802
  --> https://bugs.webkit.org/attachment.cgi?id=448802
Patch v1.1

Looks good.

Please note that using the URL class’s relative URL resolution doesn’t
necessarily handle all the edge cases correctly and functions like
Document::completeURL end up having to add special cases. So please think
further on that point, for things like empty string.