[webkit-reviews] review granted: [Bug 232841] [GPU Process] [Filters 19/23] Remove the dependency from FilterEffect to its inputs : [Attachment 448798] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 10 14:16:32 PST 2022


Darin Adler <darin at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 232841: [GPU Process] [Filters 19/23] Remove the dependency from
FilterEffect to its inputs
https://bugs.webkit.org/show_bug.cgi?id=232841

Attachment 448798: Patch

https://bugs.webkit.org/attachment.cgi?id=448798&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 448798
  --> https://bugs.webkit.org/attachment.cgi?id=448798
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448798&action=review

Looks good, assuming tests are all passing.

> Source/WebCore/svg/graphics/filters/SVGFilterBuilder.h:62
> +    std::optional<FilterEffectVector> namedEffects(const
Vector<AtomString>&) const;

I’d suggest Span<AtomString> instead as the argument type here.


More information about the webkit-reviews mailing list