[webkit-reviews] review denied: [Bug 233195] REGRESSION (r283723): Web Inspector: CSS declarations unexpectedly removed when editing property value : [Attachment 448787] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has denied Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 233195: REGRESSION (r283723): Web Inspector: CSS declarations unexpectedly
removed when editing property value
https://bugs.webkit.org/show_bug.cgi?id=233195

Attachment 448787: Patch

https://bugs.webkit.org/attachment.cgi?id=448787&action=review




--- Comment #6 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 448787
  --> https://bugs.webkit.org/attachment.cgi?id=448787
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448787&action=review

r-, as this is missing an entry in LayoutTests/ChangeLog

looks good otherwise tho :)

> LayoutTests/inspector/css/modify-css-property.html:328
> +		   resolve();

NIT: Rather than capture `resolve` and manually calling it (which btw wont
prevent the rest of the code from being run, so you may get weird other
output), I'd suggest making it an `async test() { ... }` and using `throw "No
declaration found.";` instead.

> LayoutTests/inspector/css/modify-css-property.html:343
> +	       InspectorTest.expectEqual(styleDeclaration.text, ``, `Style
declaration text should be empty.`);

NIT: Both of these should be regular double-quoted strings, not template
strings.

> LayoutTests/inspector/css/modify-css-property.html:346
> +	       let expectedStyleText = `\n    border-color: darkseagreen;\n`;

ditto (:343)

Also, why not inline this?

> LayoutTests/inspector/css/modify-css-property.html:347
> +	       InspectorTest.expectEqual(styleDeclaration.text,
expectedStyleText, `Style declaration text should have new property name.`);

ditto (:343)