[webkit-reviews] review granted: [Bug 235022] Modal container observer should classify elements that are styled like clickable controls : [Attachment 448772] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 10 12:58:12 PST 2022


Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 235022: Modal container observer should classify elements that are styled
like clickable controls
https://bugs.webkit.org/show_bug.cgi?id=235022

Attachment 448772: Patch

https://bugs.webkit.org/attachment.cgi?id=448772&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 448772
  --> https://bugs.webkit.org/attachment.cgi?id=448772
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448772&action=review

> Source/WebCore/page/ModalContainerObserver.cpp:300
> +static bool listensForUserActivation(const Element& element)

This seems like a handy thing, I'm surprised it's unique to this code.


More information about the webkit-reviews mailing list