[webkit-reviews] review granted: [Bug 234984] REGRESSION(r287683): <dialog> elements inside clipped/overflowed elements are no longer shown : [Attachment 448626] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 234984: REGRESSION(r287683): <dialog> elements inside clipped/overflowed
elements are no longer shown
https://bugs.webkit.org/show_bug.cgi?id=234984

Attachment 448626: Patch

https://bugs.webkit.org/attachment.cgi?id=448626&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 448626
  --> https://bugs.webkit.org/attachment.cgi?id=448626
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448626&action=review

> Source/WebCore/rendering/RenderLayer.cpp:4549
> +    auto parentLayer = establishesTopLayer() ? renderer().view().layer() :
parent();

Calling this 'parentLayer' is confusing because it's not always the parent
layer. Maybe containerLayer?