[webkit-reviews] review granted: [Bug 234917] [css-grid] Fix rounding of distributed free space to flexible tracks : [Attachment 448739] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 10 09:02:47 PST 2022

Darin Adler <darin at apple.com> has granted zsun at igalia.com's request for review:
Bug 234917: [css-grid] Fix rounding of distributed free space to flexible

Attachment 448739: Patch


--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 448739
  --> https://bugs.webkit.org/attachment.cgi?id=448739

View in context: https://bugs.webkit.org/attachment.cgi?id=448739&action=review

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:740
> +	   auto stretchedSize = LayoutUnit(frShare);

This truncates rather than rounding, so it rounds toward zero. Did we want to
round in the more traditional way instead? We would do this with the equivalent
of LayoutUnit::fromFloatRound, although I suppose we would want a double
version of that?

Looks like the problem is fixed without that, though, so it may be optional.

More information about the webkit-reviews mailing list