[webkit-reviews] review granted: [Bug 234697] [CSS Color 4] CSS color() function should not clamp channels to the 0-1 range : [Attachment 448751] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 10 08:58:19 PST 2022


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 234697: [CSS Color 4] CSS color() function should not clamp channels to the
0-1 range
https://bugs.webkit.org/show_bug.cgi?id=234697

Attachment 448751: Patch

https://bugs.webkit.org/attachment.cgi?id=448751&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 448751
  --> https://bugs.webkit.org/attachment.cgi?id=448751
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448751&action=review

> Source/WebCore/ChangeLog:8
> +	   Allow components outside the the 0-1 range for RGB color function
types (e.g. color(srgb -2 15 100)).

Is this only for code paths that already store the components as floating point
values? Does this affect performance in any cases that before would round down
to [0,255] integers?


More information about the webkit-reviews mailing list