[webkit-reviews] review granted: [Bug 126142] REGRESSION (Lazy tree creation): css3/calc/transitions-dependent.html is frequently failing : [Attachment 444485] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Diego Pino <dpino at igalia.com>'s
request for review:
Bug 126142: REGRESSION (Lazy tree creation):
css3/calc/transitions-dependent.html is frequently failing
https://bugs.webkit.org/show_bug.cgi?id=126142

Attachment 444485: Patch

https://bugs.webkit.org/attachment.cgi?id=444485&action=review




--- Comment #10 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 444485
  --> https://bugs.webkit.org/attachment.cgi?id=444485
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444485&action=review

> LayoutTests/TestExpectations:1209
> +css3/calc/transitions-dependent.html [ DumpJSConsoleLogInStdErr ]

What does this test dump to console? DumpJSConsoleLogInStdErr is supposed to
only be used for imported tests, which we cannot modify.

> LayoutTests/css3/calc/transitions-dependent.html:77
> +  let element = document.getElementById(elementId);

Looks like existing code in this test uses four-space indentation.

> LayoutTests/css3/calc/transitions-dependent.html:111
> +  window.testRunner.waitUntilDone();

Ditto. Also, no need to prefix with window. on this line.