[webkit-reviews] review granted: [Bug 234632] [LBSE] Introduce SVGBoundingBoxComputation : [Attachment 448736] Patch, v3

[bugzilla-daemon at webkit.org]

Rob Buis <rbuis at igalia.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 234632: [LBSE] Introduce SVGBoundingBoxComputation
https://bugs.webkit.org/show_bug.cgi?id=234632

Attachment 448736: Patch, v3

https://bugs.webkit.org/attachment.cgi?id=448736&action=review




--- Comment #10 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 448736
  --> https://bugs.webkit.org/attachment.cgi?id=448736
Patch, v3

View in context: https://bugs.webkit.org/attachment.cgi?id=448736&action=review

> Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp:80
> +#endif

Likely not needed?

> Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp:132
> +    auto transformationMatrixFromChild = [](const RenderLayerModelObject&
child) -> std::optional<TransformationMatrix> {

Much more common to write lambda's like "[] (...".

> Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp:153
> +	       return;

Cool logic ;)

> Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp:221
> +	   box.intersect(FloatRect(overflowClipRect));

The explicit conversion is likely not needed.