[webkit-reviews] review granted: [Bug 234992] [LBSE] Begin layer-aware RenderSVGRect implementation : [Attachment 448728] Patch, v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 10 02:41:49 PST 2022

Rob Buis <rbuis at igalia.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 234992: [LBSE] Begin layer-aware RenderSVGRect implementation

Attachment 448728: Patch, v2


--- Comment #4 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 448728
  --> https://bugs.webkit.org/attachment.cgi?id=448728
Patch, v2

View in context: https://bugs.webkit.org/attachment.cgi?id=448728&action=review

> Source/WebCore/rendering/svg/RenderSVGRect.h:33
> +#include "SVGRectElement.h"

Could this be forward reference?

> Source/WebCore/svg/SVGRectElement.cpp:94
> +    if (0 && document().settings().layerBasedSVGEngineEnabled())

Maybe false is nicer.

More information about the webkit-reviews mailing list