[webkit-reviews] review granted: [Bug 235011] [LFC][IFC] imported/w3c/web-platform-tests/css/css-text/word-break/word-break-normal-ar-000.html fails with incorrect run position : [Attachment 448693] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 8 23:07:25 PST 2022

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 235011: [LFC][IFC]
0.html fails with incorrect run position

Attachment 448693: Patch


--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 448693
  --> https://bugs.webkit.org/attachment.cgi?id=448693

View in context: https://bugs.webkit.org/attachment.cgi?id=448693&action=review

> Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h:47
> +    enum class UseTrailingWhitespaceMeasuringQuirk : uint8_t { Yes, No };

It is more like an optimization rather than quirk.

It would be good to add a comment that explains what this does and why it is ok
in LTR.

More information about the webkit-reviews mailing list