[webkit-reviews] review granted: [Bug 234995] Make FullscreenManager::requestFullscreenForElement more robust : [Attachment 448647] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 7 17:31:27 PST 2022


Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 234995: Make FullscreenManager::requestFullscreenForElement more robust
https://bugs.webkit.org/show_bug.cgi?id=234995

Attachment 448647: Patch

https://bugs.webkit.org/attachment.cgi?id=448647&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 448647
  --> https://bugs.webkit.org/attachment.cgi?id=448647
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448647&action=review

> Source/WebCore/dom/FullscreenManager.cpp:116
> +    m_pendingFullscreenElement = RefPtr { element.ptr() };

I don’t think we have to write RefPtr here.


More information about the webkit-reviews mailing list