[webkit-reviews] review granted: [Bug 234974] A/B comparison tests fail trying to look up fuzzy match tolerance : [Attachment 448615] Patch

[bugzilla-daemon at webkit.org]

Aditya Keerthi <akeerthi at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 234974: A/B comparison tests fail trying to look up fuzzy match tolerance
https://bugs.webkit.org/show_bug.cgi?id=234974

Attachment 448615: Patch

https://bugs.webkit.org/attachment.cgi?id=448615&action=review




--- Comment #2 from Aditya Keerthi <akeerthi at apple.com> ---
Comment on attachment 448615
  --> https://bugs.webkit.org/attachment.cgi?id=448615
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448615&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:416
> +	       fuzzy_tolerance = None
> +	       if allow_fuzzy_tolerance:
> +		   fuzzy_tolerance =
self._fuzzy_tolerance_for_reference(reference_filename)

Not sure what our Python style guide says, but ternary might be nice:
`fuzzy_tolerance = self._fuzzy_tolerance_for_reference(reference_filename) if
allow_fuzzy_tolerance else None`.