[webkit-reviews] review granted: [Bug 234951] Adopt linkedOnOrAfter() in more places : [Attachment 448576] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 7 10:48:28 PST 2022

Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 234951: Adopt linkedOnOrAfter() in more places

Attachment 448576: Patch


--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 448576
  --> https://bugs.webkit.org/attachment.cgi?id=448576

View in context: https://bugs.webkit.org/attachment.cgi?id=448576&action=review

This seems fine to me, given that we are already going down the
`PLATFORM(IOS_FAMILY)` path on watchOS anyways (since `PLATFORM(WATCH)` is
never defined on watchOS).

It would be nice if some JSC folks could take a look as well.

Separately, maybe we should consider actually avoiding this check on watchOS?

> Source/JavaScriptCore/API/tests/testapi.mm:-2744


More information about the webkit-reviews mailing list