[webkit-reviews] review granted: [Bug 234876] Enable WebRTC for Mac Catalyst : [Attachment 448579] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 7 09:27:24 PST 2022


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 234876: Enable WebRTC for Mac Catalyst
https://bugs.webkit.org/show_bug.cgi?id=234876

Attachment 448579: Patch

https://bugs.webkit.org/attachment.cgi?id=448579&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 448579
  --> https://bugs.webkit.org/attachment.cgi?id=448579
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448579&action=review

> Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:58
> +    , m_currentNativePresentationTimeStamp { PAL::kCMTimeInvalid }
> +    , m_currentOutputPresentationTimeStamp { PAL::kCMTimeInvalid }
> +    , m_remainingPrimeDuration { PAL::kCMTimeInvalid }

Why make this change?

>
Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:184
> +RetainPtr<CVPixelBufferRef> createBlackPixelBuffer(size_t width, size_t
height)

Maybe move this to RealtimeOutgoingVideoSourceCocoa.mm?


More information about the webkit-reviews mailing list