[webkit-reviews] review granted: [Bug 234955] Inserting a new @keyframes rule does not start animations that already used this name : [Attachment 448583] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 7 06:15:54 PST 2022


Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 234955: Inserting a new @keyframes rule does not start animations that
already used this name
https://bugs.webkit.org/show_bug.cgi?id=234955

Attachment 448583: Patch

https://bugs.webkit.org/attachment.cgi?id=448583&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 448583
  --> https://bugs.webkit.org/attachment.cgi?id=448583
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448583&action=review

> Source/WebCore/style/Styleable.cpp:216
> +    for (size_t i = 0; i < animations.size(); ++i) {

Might be good for the AnimationList to expose the underlying const vector so
these could use range-for iteration.


More information about the webkit-reviews mailing list