[webkit-reviews] review granted: [Bug 234921] Remove IPC::SharedBufferDataReference and use IPC::SharedBufferCopy instead : [Attachment 448581] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 7 05:42:37 PST 2022


youenn fablet <youennf at gmail.com> has granted Jean-Yves Avenard [:jya]
<jean-yves.avenard at apple.com>'s request for review:
Bug 234921: Remove IPC::SharedBufferDataReference and use IPC::SharedBufferCopy
instead
https://bugs.webkit.org/show_bug.cgi?id=234921

Attachment 448581: Patch

https://bugs.webkit.org/attachment.cgi?id=448581&action=review




--- Comment #14 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 448581
  --> https://bugs.webkit.org/attachment.cgi?id=448581
Patch

As discussed offline, it might be good to fix the perf regression.
In the end, we might want on receiver side to pass SharedBufferCopy&& from
which we can extract Ref<SharedBuffer>.
Then we can remove SharedBufferCopy::data.


More information about the webkit-reviews mailing list