[webkit-reviews] review granted: [Bug 234596] Microphone device filtering heuristic is too harsh : [Attachment 448506] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted  review:
Bug 234596: Microphone device filtering heuristic is too harsh
https://bugs.webkit.org/show_bug.cgi?id=234596

Attachment 448506: Patch

https://bugs.webkit.org/attachment.cgi?id=448506&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 448506
  --> https://bugs.webkit.org/attachment.cgi?id=448506
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448506&action=review

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:114
> +static bool isValidCaptureDevice(const CoreAudioCaptureDevice& device, bool
enableTapEnabledFiltering)

Nit: "enable...Enabled..." is slightly confusing, maybe something like
"filterTapEnabledDevices" instead?

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:130
> +	       RELEASE_LOG(WebRTC, "Ignoring output device that have input only
for echo cancellation");

Not new, but: s/have/has/

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:271
> +static inline Vector<CoreAudioCaptureDevice> computeAudioDeviceList(bool
enableTapEnabledFiltering)

Same comment as above.

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:351
> +    auto audioDevices = computeAudioDeviceList(m_enableTapEnabledFiltering);

Ditto

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.h:49
> +    void setEnableTapEnabledFiltering(bool doFiltering) {
m_enableTapEnabledFiltering = doFiltering; }

Ditto