[webkit-reviews] review requested: [Bug 234393] Web Inspector: Unhandled exception when moving cursor mid-token after receiving CSS property name completions : [Attachment 448505] Patch 1.2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 6 08:50:52 PST 2022


Razvan Caliman <rcaliman at apple.com> has asked  for review:
Bug 234393: Web Inspector: Unhandled exception when moving cursor mid-token
after receiving CSS property name completions
https://bugs.webkit.org/show_bug.cgi?id=234393

Attachment 448505: Patch 1.2

https://bugs.webkit.org/attachment.cgi?id=448505&action=review




--- Comment #8 from Razvan Caliman <rcaliman at apple.com> ---
Created attachment 448505

  --> https://bugs.webkit.org/attachment.cgi?id=448505&action=review

Patch 1.2

Address code review comments:
- dropped clamping of `adjustedCaretPosition`
- updated Changelog bug name
- added FIXME reference to bug for supporting mid-token completions


More information about the webkit-reviews mailing list