[webkit-reviews] review granted: [Bug 234901] Web Inspector: Layers: add reference page button : [Attachment 448436] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 5 16:25:57 PST 2022

Patrick Angle <pangle at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 234901: Web Inspector: Layers: add reference page button

Attachment 448436: Patch


--- Comment #3 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 448436
  --> https://bugs.webkit.org/attachment.cgi?id=448436

View in context: https://bugs.webkit.org/attachment.cgi?id=448436&action=review


> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.css:73
> +    bottom: 6px;
> +    inset-inline-end: 6px;

Are these the measurements we want to use for any content view? If so is there
any value in using the same rule for both this and the Audits tab so that we
are less likely to use different measurements in the future?

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:180
> +	   this.element.appendChild(WI.createReferencePageLink("layers-tab"));

NIT: Can we move this to before the call to `_animate()` with the other
`appendChild`? Makes it easier to see what we add to the view IMO.

More information about the webkit-reviews mailing list