[webkit-reviews] review granted: [Bug 234892] Make WebResourceLoadStatisticsStore a MessageReceiver : [Attachment 448415] Patch

[bugzilla-daemon at webkit.org]

John Wilander <wilander at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 234892: Make WebResourceLoadStatisticsStore a MessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=234892

Attachment 448415: Patch

https://bugs.webkit.org/attachment.cgi?id=448415&action=review




--- Comment #4 from John Wilander <wilander at apple.com> ---
Comment on attachment 448415
  --> https://bugs.webkit.org/attachment.cgi?id=448415
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448415&action=review

r=me bar addressing the test failures.

>
Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:-85
> -void
WebResourceLoadStatisticsStore::setNotifyPagesWhenDataRecordsWereScanned(bool
value)

Was this intentionally deleted? Doesn't seem to be part of the gist of this
patch. A comment on why it can be removed would be good.

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:539
>  void NetworkProcess::updatePrevalentDomainsToBlockCookiesFor(PAL::SessionID
sessionID, const Vector<RegistrableDomain>& domainsToBlock,
CompletionHandler<void()>&& completionHandler)

Was this particular one not moved?

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:684
> +void
NetworkProcess::setShouldEnableSameSiteStrictEnforcementForTesting(PAL::Session
ID sessionID, WebCore::SameSiteStrictEnforcementEnabled enabled,
CompletionHandler<void()>&& completionHandler)

Nice catch.

> Source/WebKit/UIProcess/WebPageProxy.cpp:5572
> +   
websiteDataStore().networkProcess().send(Messages::WebResourceLoadStatisticsSto
re::LogFrameNavigation(RegistrableDomain { targetURL }, RegistrableDomain {
pageURL }, RegistrableDomain { sourceURL }, isRedirect, frame.isMainFrame(),
MonotonicTime::now() - m_didFinishDocumentLoadForMainFrameTimestamp,
wasPotentiallyInitiatedByUser), sessionID().toUInt64());

Would be nice to be able to send session ID objects directly.