[webkit-reviews] review canceled: [Bug 234503] [Win] MSVC reports "DumpRenderTree.cpp(633): error C2362: initialization of 'length' is skipped by 'goto exit'" with /std:c++20 : [Attachment 447766] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 4 22:53:10 PST 2022


Fujii Hironori <Hironori.Fujii at sony.com> has canceled Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 234503: [Win] MSVC reports "DumpRenderTree.cpp(633): error C2362:
initialization of 'length' is skipped by 'goto exit'" with /std:c++20
https://bugs.webkit.org/show_bug.cgi?id=234503

Attachment 447766: Patch

https://bugs.webkit.org/attachment.cgi?id=447766&action=review




--- Comment #9 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 447766
  --> https://bugs.webkit.org/attachment.cgi?id=447766
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447766&action=review

> Tools/DumpRenderTree/win/DumpRenderTree.cpp:602
> +	   if (SUCCEEDED(::SafeArrayUnlock(arrayPtr)))

This code has another bug. I'm going to fix this typo and the bug in the
following ticket.
Bug 234870 – [Win][DumpRenderTree] dumpHistoryItem leaks a SafeArray


More information about the webkit-reviews mailing list