[webkit-reviews] review requested: [Bug 234615] Web Inspector: Sources: cannot copy grouping of blackboxed call frames : [Attachment 448357] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 4 17:56:14 PST 2022

Devin Rousso <drousso at apple.com> has asked  for review:
Bug 234615: Web Inspector: Sources: cannot copy grouping of blackboxed call

Attachment 448357: Patch


--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Created attachment 448357

  --> https://bugs.webkit.org/attachment.cgi?id=448357&action=review


The only downside I can think of as a result of this is that up/down will now
traverse through blackboxed call frame groups, meaning that it's an extra step
(or more) to select the previous/next call frame using the arrow keys when
there's a blackboxed call frame group in the middle.  I don't think this is
that big of a deal though given that this interaction requires focus to be in
the Call Stack section and can be easily avoided using the mouse (which I'd bet
is more commonly used than the arrow keys).

We could make it so that selecting a blackboxed call frame group tree element
will jump to the location of the topmost blackboxed call frame, but that maybe
could be a bit confusing since we don't actually show that call frame in the
Call Stack section.  Either way, this can be a followup.

More information about the webkit-reviews mailing list