[webkit-reviews] review granted: [Bug 234851] ASSERTION FAILED: pathnames.size() == sandboxExtensionsHandleArray.size() in WebKit::WebPlatformStrategies::getPathnamesForType() : [Attachment 448335] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 234851: ASSERTION FAILED: pathnames.size() ==
sandboxExtensionsHandleArray.size() in
WebKit::WebPlatformStrategies::getPathnamesForType()
https://bugs.webkit.org/show_bug.cgi?id=234851

Attachment 448335: Patch

https://bugs.webkit.org/attachment.cgi?id=448335&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 448335
  --> https://bugs.webkit.org/attachment.cgi?id=448335
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448335&action=review

> Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:175
>	       // On iOS, files are copied into app's container upon paste.

This is a confusing comment, because it’s in a Mac-specific code section, but
says "On iOS".

> Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:180
> +		   return SandboxExtension::createHandle(filename,
SandboxExtension::Type::ReadOnly).value_or(SandboxExtension::Handle { });

Can we omit the SandboxExtension::Handle in the value_or call?