[webkit-reviews] review granted: [Bug 234677] Use ICU instead of relying on hard-coded string equality checks in ModalContainerControlClassifier : [Attachment 447953] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 234677: Use ICU instead of relying on hard-coded string equality checks in
ModalContainerControlClassifier
https://bugs.webkit.org/show_bug.cgi?id=234677

Attachment 447953: Patch

https://bugs.webkit.org/attachment.cgi?id=447953&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 447953
  --> https://bugs.webkit.org/attachment.cgi?id=447953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447953&action=review

> Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.mm:81
> +class ScopedSpoofChecker {

The word "Scoped" seems unnecessary? I don't think every RAII thing needs
"Scoped" in the name. ScopedRefPtr?

Is just a SpoofChecker. Or StringSpoofChecker or something.