[webkit-reviews] review granted: [Bug 234446] ModalContainerObserver should search for text in subframes : [Attachment 448188] Rebase on trunk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 4 13:08:32 PST 2022

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 234446: ModalContainerObserver should search for text in subframes

Attachment 448188: Rebase on trunk


--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 448188
  --> https://bugs.webkit.org/attachment.cgi?id=448188
Rebase on trunk

View in context: https://bugs.webkit.org/attachment.cgi?id=448188&action=review

> Source/WebCore/page/ModalContainerObserver.cpp:67
> -    if (!document.url().protocolIsInHTTPFamily())
> +    if (!document.topDocument().url().protocolIsInHTTPFamily())

Should this check both documents? (I'm not sure what the HTTP-family check is
*for*, so the answer could easily be yes OR no, I'm not sure)

More information about the webkit-reviews mailing list