[webkit-reviews] review granted: [Bug 234836] [JSC] Implement Temporal.Now.instant() : [Attachment 448273] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 4 10:33:03 PST 2022


Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 234836: [JSC] Implement Temporal.Now.instant()
https://bugs.webkit.org/show_bug.cgi?id=234836

Attachment 448273: Patch

https://bugs.webkit.org/attachment.cgi?id=448273&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 448273
  --> https://bugs.webkit.org/attachment.cgi?id=448273
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448273&action=review

Seems good to me.

> Source/WTF/wtf/PlatformUse.h:-92
> -/* On Windows, use QueryPerformanceCounter by default */
> -#if OS(WINDOWS)
> -#define USE_QUERY_PERFORMANCE_COUNTER  1
> -#endif

So the assumption is that nobody on Windows has a reason to turn this off? I
suppose we should mention that in the ChangeLog.


More information about the webkit-reviews mailing list