[webkit-reviews] review granted: [Bug 234835] [GTK][a11y] Use invalid as role for detached objects in ATSPI : [Attachment 448269] Patch

[bugzilla-daemon at webkit.org]

Joanmarie Diggs <jdiggs at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 234835: [GTK][a11y] Use invalid as role for detached objects in ATSPI
https://bugs.webkit.org/show_bug.cgi?id=234835

Attachment 448269: Patch

https://bugs.webkit.org/attachment.cgi?id=448269&action=review




--- Comment #2 from Joanmarie Diggs <jdiggs at igalia.com> ---
Comment on attachment 448269
  --> https://bugs.webkit.org/attachment.cgi?id=448269
Patch

r+ but with a question: Is there any way to know what the role of the detached
object used to be? (if nothing else as a TODO for the future).

FWIW, INVALID and UNKNOWN have the same degree of usefulness (read "none
whatsoever") to Orca. Knowing the role of something in the process of being
destroyed improves the likelihood that Orca can recover / clean up stored
state, etc.