[webkit-reviews] review granted: [Bug 234834] [LFC][IFC] fast/text/combining-mark-paint.html is failing (complex text) : [Attachment 448264] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 234834: [LFC][IFC] fast/text/combining-mark-paint.html is failing (complex
text)
https://bugs.webkit.org/show_bug.cgi?id=234834

Attachment 448264: Patch

https://bugs.webkit.org/attachment.cgi?id=448264&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 448264
  --> https://bugs.webkit.org/attachment.cgi?id=448264
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448264&action=review

> Source/WebCore/ChangeLog:8
> +	   Apparently it's perfectly valid to have zero width unicode character
(e.g. macron) and

French again :(

> Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:105
> +		   && (!canUseSimpleFontCodePath ||
glyphData.font->widthForGlyph(glyphData.glyph)))

Weird that this is code path specific rather than based which glyph it is.