[webkit-reviews] review granted: [Bug 234823] [Web Animations] changing the effect of a transition should no longer have it marked as running : [Attachment 448244] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 234823: [Web Animations] changing the effect of a transition should no
longer have it marked as running
https://bugs.webkit.org/show_bug.cgi?id=234823

Attachment 448244: Patch

https://bugs.webkit.org/attachment.cgi?id=448244&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 448244
  --> https://bugs.webkit.org/attachment.cgi?id=448244
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448244&action=review

> Source/WebCore/animation/DeclarativeAnimation.cpp:242
> +    auto effectChanged = effect() != newEffect;
> +
> +    WebAnimation::setEffect(WTFMove(newEffect));

Why would you call setEffect if !effectChanged?