[webkit-reviews] review granted: [Bug 234817] [JSC] Fix Intl.PluralRules.selectRange input validation : [Attachment 448230] Patch

[bugzilla-daemon at webkit.org]

Alexey Shvayka <ashvayka at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 234817: [JSC] Fix Intl.PluralRules.selectRange input validation
https://bugs.webkit.org/show_bug.cgi?id=234817

Attachment 448230: Patch

https://bugs.webkit.org/attachment.cgi?id=448230&action=review




--- Comment #2 from Alexey Shvayka <ashvayka at apple.com> ---
Comment on attachment 448230
  --> https://bugs.webkit.org/attachment.cgi?id=448230
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448230&action=review

> Source/JavaScriptCore/ChangeLog:8
> +	   Add specified argument validation to Intl.PluralRules.selectRange.

Should we include a spec link
(https://tc39.es/proposal-intl-numberformat-v3/out/pluralrules/proposed.html#se
c-intl.pluralrules.prototype.selectrange)? It's a bit non-trivial to find.

> Source/JavaScriptCore/runtime/IntlPluralRules.cpp:288
> +    if (isNegativeZero(end) && start >= 0)

Hmm, this is interesting: spec's numeric operators (< / <= / > / >=) for Number
should "refer to the relevant operations within IEEE 754-2019" (paragraph 3 of
https://tc39.es/ecma262/multipage/notational-conventions.html#sec-mathematical-
operations).
Does the IEEE 754 differentiate between -0 and 0 in comparison operators?
Comparing `-0.0 < 0.0` C++ doubles yields `false`.