[webkit-reviews] review granted: [Bug 234812] Refactor code creating css values and lists for animation and transition properties : [Attachment 448225] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 3 04:29:21 PST 2022


Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 234812: Refactor code creating css values and lists for animation and
transition properties
https://bugs.webkit.org/show_bug.cgi?id=234812

Attachment 448225: Patch

https://bugs.webkit.org/attachment.cgi?id=448225&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 448225
  --> https://bugs.webkit.org/attachment.cgi?id=448225
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448225&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1450
> +void
ComputedStyleExtractor::addCSSValueForAnimationPropertyToList(CSSPropertyID
property, const Animation* animation, CSSValueList& list)

I'd make the target list the first argument.


More information about the webkit-reviews mailing list