[webkit-reviews] review granted: [Bug 234077] [selectors] :focus-visible not matching on accessKey focus after focusing something via mouse : [Attachment 448219] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 234077: [selectors] :focus-visible not matching on accessKey focus after
focusing something via mouse
https://bugs.webkit.org/show_bug.cgi?id=234077

Attachment 448219: Patch

https://bugs.webkit.org/attachment.cgi?id=448219&action=review




--- Comment #12 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 448219
  --> https://bugs.webkit.org/attachment.cgi?id=448219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448219&action=review

> Source/WebCore/dom/Element.h:429
> +    virtual void focusForBindings(const FocusOptions& = { });

Probably doesn't need default value.

> Source/WebCore/dom/FocusOptions.h:35
> +enum class FocusTrigger : uint8_t { Other, Click, JavaScriptBindings };

Just Bindings is enough.