[webkit-reviews] review granted: [Bug 234792] "animation" shorthand should list all longhand values when serializing : [Attachment 448171] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 2 11:44:42 PST 2022

Darin Adler <darin at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 234792: "animation" shorthand should list all longhand values when

Attachment 448171: Patch


--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 448171
  --> https://bugs.webkit.org/attachment.cgi?id=448171

View in context: https://bugs.webkit.org/attachment.cgi?id=448171&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:1662
> +		   if (property == CSSPropertyAnimationDuration)

We can and should make this code less repetitive. One function to turn a
property into a value, rather than repeating the append calls. Can just take a
property ID as an argument and return a Ref<>. A lambda if you prefer but I
think a separate named function would be good.

More information about the webkit-reviews mailing list