[webkit-reviews] review granted: [Bug 234794] [JSC] Use emitPutProperty / emitGetPropertyValue consistently to handle private names in edge cases : [Attachment 448173] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 2 08:09:14 PST 2022


Alexey Shvayka <ashvayka at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 234794: [JSC] Use emitPutProperty / emitGetPropertyValue consistently to
handle private names in edge cases
https://bugs.webkit.org/show_bug.cgi?id=234794

Attachment 448173: Patch

https://bugs.webkit.org/attachment.cgi?id=448173&action=review




--- Comment #2 from Alexey Shvayka <ashvayka at apple.com> ---
Comment on attachment 448173
  --> https://bugs.webkit.org/attachment.cgi?id=448173
Patch

This is super neat!

Could you please check if the same change is necessary for
ShortCircuitReadModifyDotNode::emitBytecode()? Related nodes (AssignDotNode,
ReadModifyDotNode) all perform emitPutProperty / emitGetPropertyValue.


More information about the webkit-reviews mailing list