[webkit-reviews] review granted: [Bug 234793] [Web Animations] getKeyframes() should return an empty object when there are no animatable properties in @keyframes rule : [Attachment 448172] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 234793: [Web Animations] getKeyframes() should return an empty object when
there are no animatable properties in @keyframes rule
https://bugs.webkit.org/show_bug.cgi?id=234793

Attachment 448172: Patch

https://bugs.webkit.org/attachment.cgi?id=448172&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 448172
  --> https://bugs.webkit.org/attachment.cgi?id=448172
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448172&action=review

> Source/WebCore/rendering/style/KeyframeList.cpp:139
> +    for (auto cssPropertyId : m_properties) {
> +	   if (CSSPropertyAnimation::isPropertyAnimatable(cssPropertyId))
> +	       return true;

Shame there isn't the equivalent of Array.some on Vector.