[webkit-reviews] review granted: [Bug 237170] [CMake] Disabling ENABLE_WEBCORE is ignored when cmake configuration runs again. : [Attachment 453425] PATCH

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has granted  review:
Bug 237170: [CMake] Disabling ENABLE_WEBCORE is ignored when cmake
configuration runs again.
https://bugs.webkit.org/show_bug.cgi?id=237170

Attachment 453425: PATCH

https://bugs.webkit.org/attachment.cgi?id=453425&action=review




--- Comment #5 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 453425
  --> https://bugs.webkit.org/attachment.cgi?id=453425
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=453425&action=review

> Source/cmake/WebKitCommon.cmake:18
> +    option(ENABLE_WEBKIT "Enable building WebKit" ON)

Some ports set these values OFF by default.
It'd be nice if we can change the default value of these options.
I think there two ways to do so.
1. Using option twice, in WebKitCommon.cmake and Options${PORT}.cmake.
2. Adding new variables, for example, ENABLE_WEBCORE_DEFAULT.
But, it seemingly needs some refactoring. I don't object landing this patch if
you want.