[webkit-reviews] review granted: [Bug 237283] Migrate third-party IndexedDB data to GeneralStorageDirectory : [Attachment 453422] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 237283: Migrate third-party IndexedDB data to GeneralStorageDirectory
https://bugs.webkit.org/show_bug.cgi?id=237283

Attachment 453422: Patch

https://bugs.webkit.org/attachment.cgi?id=453422&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 453422
  --> https://bugs.webkit.org/attachment.cgi?id=453422
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453422&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:407
> +    auto preferences = (__bridge WKPreferencesRef)[configuration
preferences];

Why cast to C API?

Let's just use the Cocoa API:
`[[configuration preferences]
_setStorageBlockingPolicy:_WKStorageBlockingPolicyAllowAll];`

You may have to include WKPreferencesPrivate.h if not already included.

Mixing C and Cocoa API is a bit ugly :)