[webkit-reviews] review canceled: [Bug 223504] [css-grid] Set hasIntrinsicWidth & hasIntrinsicHeight properties for SVG element's intrinsic size : [Attachment 453361] Rebase the original fix

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has canceled Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 223504: [css-grid] Set hasIntrinsicWidth & hasIntrinsicHeight properties
for SVG element's intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=223504

Attachment 453361: Rebase the original fix

https://bugs.webkit.org/attachment.cgi?id=453361&action=review




--- Comment #18 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 453361
  --> https://bugs.webkit.org/attachment.cgi?id=453361
Rebase the original fix

(In reply to Darin Adler from comment #17)
> Comment on attachment 453361 [details]
> Rebase the original fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=453361&action=review
> 
> > Source/WebCore/rendering/RenderBox.h:615
> > +	 virtual void computeIntrinsicRatioInformation(FloatSize& /*
intrinsicSize */, double& /* intrinsicRatio */, bool& /* hasIntrinsicWidth */,
bool& /* hasIntrinsicHeight */) const { }
> 
> In future I think this needs to start returning a structure, not take 4 out
> arguments.

Sounds good! Since this patch touches all of the method signatures anyways, I
think we should just do it as a part of this change.