[webkit-reviews] review granted: [Bug 237065] [macOS] TestWebKitAPI.WebKit.MigrateLocalStorageDataToGeneralStorageDirectory is a flaky failure : [Attachment 453368] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 237065: [macOS]
TestWebKitAPI.WebKit.MigrateLocalStorageDataToGeneralStorageDirectory is a
flaky failure
https://bugs.webkit.org/show_bug.cgi?id=237065

Attachment 453368: Patch

https://bugs.webkit.org/attachment.cgi?id=453368&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 453368
  --> https://bugs.webkit.org/attachment.cgi?id=453368
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453368&action=review

> Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h:43
> +#include <wtf/WeakHashSet.h>

Should not need this in the header just to declare a function returning a
reference to a WeakHashSet. Forward.h should suffice.

> Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h:74
> +    static WeakHashSet<NetworkStorageManager>& allNetworkStorageManagers();

I suggest we publish a forEachNetworkStorageManager function for
NetworkProcess.cpp to use instead of of publishing a read/write reference to a
WeakHashSet; would be nice to keep the WeakHashSet as a hidden implementation
detail of this class.