[webkit-reviews] review granted: [Bug 237128] [macOS][REGRESSION] (r289518): Form controls are scaled twice on Retina display : [Attachment 453427] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 28 14:43:26 PST 2022
Darin Adler <darin at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 237128: [macOS][REGRESSION] (r289518): Form controls are scaled twice on
Retina display
https://bugs.webkit.org/show_bug.cgi?id=237128
Attachment 453427: Patch
https://bugs.webkit.org/attachment.cgi?id=453427&action=review
--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 453427
--> https://bugs.webkit.org/attachment.cgi?id=453427
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=453427&action=review
r=mews
> Source/WebCore/ChangeLog:9
> + Using the name GraphicsContext::createImageBuffer() for different
behaviors
I love the idea of using three different names for these three different
functions. But I have no idea when each of these should be used when; the names
do not yet make that clear to me. Some of these create bigger higher-resolution
buffers. Are those called "scaled" buffers? What does "aligned" mean, scaled to
match an underlying context’s resolution?
> Source/WebCore/ChangeLog:19
> + It can be forced to create a none accelerated local ImageBuffer
for example.
"none accelerated" -> "non-accelerated"
> Source/WebCore/ChangeLog:32
> + To Fix this bug:
Nit: "Fix" -> "fix"
> Source/WebCore/platform/graphics/RenderingMode.h:39
> +enum class RenderingMethod : uint8_t { Local, DisplayList };
uint8_t -> bool
More information about the webkit-reviews
mailing list